iwubcode
commented
2 years ago The current preview solution seemed like it needed some improvement (it creates a random temp file somewhere and going out of the actual app was not ideal) so I'm very excited for this.
Preview Image should accept multiple image inputs (accept an iterable somehow in potential new iteration system?). All simultaneous inputs (so one set per iteration if chain is iterated) would be opened in different tabs of the Preview Window (as seen in the tab bar in the mockup).
Suggestion - instead of a tab at the top. What if you had a scrollable pane on the left with a small image preview along with the name? At least for the things I upscale, the name is auto-generated and its not always easy to distinguish from that alone.
joeyballentine
Arcitec
Running the Preview Image node would pop up a custom chakra window. This custom window would have the following features, as shown in the mockup below: 1) Window should be fully resizable. 2) Chain should pause while window is open to prevent window spam. 3) Preview Image should accept multiple image inputs (accept an iterable somehow in potential new iteration system?). All simultaneous inputs (so one set per iteration if chain is iterated) would be opened in different tabs of the Preview Window (as seen in the tab bar in the mockup). 4) The image displayed in the viewing window is swapped by clicking the appropriate tab or using the corresponding number key. Number keys would be assigned in order. If more than 10 images are permitted, could use key combos with the number keys to provide more hotkeys. 5) Scroll wheel or zoom buttons in toolbar (and maybe +/- keys) should zoom in and out of the images. Click and drag should pan the images. 6) Images should be scaled to the image with the largest dimensions (default nearest, but could allow other interpolations selectable from toolbar as well), as all tabbed images should share the same zoom scale and xy offset (that is, if you swap between different images, you should be seeing the same part of the image in the viewing window), as the primary purpose of this feature is to compare upscales of an image. 7) The Save button would pop up a save as window to save the currently selected image. Save All would save the images in all currently open tabs to a selected directory. Would need to figure out the best way to provide names for all of them, and possibly different behavior depending on whether file names are input to Preview Image. Could use a pattern like the GIMP Export all layers plugin (that plugin defaults to {image-name}-{layer-name}.png, just as an example), or save as the original input file name with the number appended, etc. 8) If possible: If preview is for a single image chain and not an iterator, have a 'Rerun current view' button that will rerun the chain on a cutout of the original image input based on the current section of the image visible in the viewing window, allowing chain to be rerun on partial images to compare specific sections only without having to process the full array.