search

chaiNNer-org / spandrel

Spandrel gives your project support for various PyTorch architectures meant for AI Super-Resolution, restoration, and inpainting. Based on the model support implemented in chaiNNer.
MIT License
149 stars 12 forks source link

Please implement RestoreFormerPlusPlus #13

Open zelenooki87 opened 1 year ago

zelenooki87 commented 1 year ago

Could you please implement support for https://github.com/wzhouxiff/RestoreFormerPlusPlus? https://github.com/wzhouxiff/RestoreFormerPlusPlus Thanks

zelenooki87 commented 1 year ago

And also I have question for devs, why not implement GPEN? I have asked number of times before...Is that hard? Thanks

joeyballentine commented 1 year ago

Implementing any arch the way i do it is difficult. As for why it was never implemented, it's because my implementation for the currently supported face models was partially based on GFPGAN's repo, which supported codeformer and restoreformer at one point.

I don't particularly enjoy adding support for new arches, so typically I wait until arches start getting used more frequently by the community. As GPEN is a bit older (and codeformer seems to basically always be better than it), I don't really have a good reason to spend time adding support for it.

If RestoreFormerPlusPlus ends up being really useful, I will definitely consider it.

zelenooki87 commented 11 months ago

Respect your time. Consider also about implementing IMHO best open source soulution for coloring grayscale images I have tried so far: https://github.com/piddnad/DDColor Thanks