search

chaiNNer-org / spandrel

Spandrel gives your project support for various PyTorch architectures meant for AI Super-Resolution, restoration, and inpainting. Based on the model support implemented in chaiNNer.
MIT License
103 stars 7 forks source link

About the definition of lk_type in plksr #256

Closed umzi2 closed 1 month ago

umzi2 commented 1 month ago

Hello, I noticed that you decided not to add a definition for lk_type in plksr. In general, I don’t think that anyone will change this parameter, but if they change it, the model will become incompatible. Can its definition and the following parameters be added? I did it like this:

joeyballentine commented 1 month ago

Thanks for letting us know about this

joeyballentine commented 1 month ago

Just FYI: your repo is still GPLv3, so me looking at it, legally speaking, means I can now not implement this in spandrel without violating your license since spandrel is now MIT licensed. RunDevelopment now has to implement this instead of me.

joeyballentine commented 1 month ago

Btw, don't take that last comment the wrong way. I appreciate you pointing this out for us -- I just wanted to mention it in case you were unaware that we now cannot reference nusselt anymore, becusse I also was not aware of that until I started implenting this