search

chaiNNer-org / spandrel

Spandrel gives your project support for various PyTorch architectures meant for AI Super-Resolution, restoration, and inpainting. Based on the model support implemented in chaiNNer.
MIT License
132 stars 9 forks source link

GRLIR: Find a good heuristic to guess `window_size` and `stripe_size` #52

Open RunDevelopment opened 9 months ago

RunDevelopment commented 9 months ago

GRLIR's window_size and stripe_size hyperparameters are undetectable, but very important to get the correct model output. When incorrect values are used, the output because unusable. See example here.

Find a way to guess/detect window_size and stripe_size for all official models.

zelenooki87 commented 9 months ago

https://github.com/HolyWu/vs-grlir/blob/master/vsgrlir/__init__.py

In holywus repo there are magical numbers. Do not know if realy working. Please test :)

zelenooki87 commented 9 months ago

Hey. You are my hero. Replaced updated heuristic fix files, everything is OK. Will play with tile settings, cause on some photos there are patches.

One thing, that happens with grlir is sometimes blue circle around humans eye pupil. Alongside that(which was expected in Hybrid VS experienced same) model are realy good, realy does great job on denoising debluring and upscaling. When I try to eliminate that with codeformer, there is bug.

image image

Thanks for great work.

RunDevelopment commented 9 months ago

Replaced updated heuristic fix files, everything is OK

That's good to hear.

When I try to eliminate that with codeformer, there is bug.

Fixed by https://github.com/chaiNNer-org/chaiNNer/pull/2337.