search

chaiNNer-org / spandrel

Spandrel gives your project support for various PyTorch architectures meant for AI Super-Resolution, restoration, and inpainting. Based on the model support implemented in chaiNNer.
MIT License
112 stars 7 forks source link

CI/lint improvements #84

Closed akx closed 6 months ago

akx commented 6 months ago

Just a tiny bit of CI and lint housekeeping. 🧹

Might be a good idea to enable the Ruff B category (with certain ignores considering it lights up like a Christmas tree for the arch code with the defaults)...

joeyballentine commented 6 months ago

I think we already ignore a lot of linting rules in the arch code, so don't feel bad about needing to do that. But I'd recommend enabling that in a separate PR

RunDevelopment commented 6 months ago

Might be a good idea to enable the Ruff B category (with certain ignores considering it lights up like a Christmas tree for the arch code with the defaults)...

Just disable B for arch/ files. We already do that for a few other categories.

Arch code is mostly unmodified from the original research projects. So we inherit a lot of code smell from researchers. That's not to put the blame on them btw. They just want to get (what is essentially) a prototype to work, so would they care about linters?