search

chaijs / chai-http

HTTP Response assertions for the Chai Assertion Library.
http://chaijs.com/plugins/chai-http
633 stars 113 forks source link

Fix for issue #254, add extended request method explanations to the README #256

Closed theodorewahle closed 5 years ago

austince commented 5 years ago

This looks great! @theodorewahle, could you just edit your commit message to something like docs: add extended request method explanations and then force push up? 

git commit --amend # change the message
git push --force # assuming your branch is set as upstream
keithamus commented 5 years ago

@austince just FYI we can use "squash and merge" to alter commits in these situations, rather than burden contributors with our commit style.

austince commented 5 years ago

@keithamus, I'm game for that - should we remove the validate-commit-msg status check then?

keithamus commented 5 years ago

@austince the validate-commit-msg check is not a required check, and so you're able to merge without it passing. I've kept it specifically not-required to allow for that scenario.