Closed Trickfilm400 closed 5 months ago
could you possibly copy the prettier config from chai-as-promised: https://github.com/chaijs/chai-as-promised/blob/master/.prettierrc.json
if we decide to change some preferences, at least the repos are in sync then
ill open a separate PR to sort the publishing
one last comment, could you also add the editorconfig from here: https://github.com/chaijs/chai-as-promised/blob/master/.editorconfig
looks good to me then 👍 super nice work 🙏
Hi,
Based on https://github.com/chaijs/chai-http/pull/310#discussion_r1589951063 here is a follow-up PR with prettier and a simple eslint configuration for styling the project files
Can we do a 5.0.0 release after this, so the NPM package corresponds to the current readme? Could be confusing otherwise. (the pipeline seems broken, issue seems like a wrong NPM token, therefore the 401 error, FWIK)
Changes:
is-ip
First step for #318
/cc @43081j