chaijs / chai-http

HTTP Response assertions for the Chai Assertion Library.
http://chaijs.com/plugins/chai-http
633 stars 113 forks source link

feat: migrate to picoquery #337

Open 43081j opened 4 months ago

43081j commented 4 months ago

Migrates from qs to picoquery, a much faster library.

We can't use URLSearchParams since we support nested syntax (and therefore assert on the top level property)

43081j commented 4 months ago

qs has a pretty awkward/messy support for mixed syntax. i think it probably makes sense to bump major because of that

for example, stuff like foo.bar[baz][0] probably works in qs but is nonsense. it should be one syntax or the other, not a mixture (e.g. foo.bar.baz[0], or foo[bar][baz][0] but not both)

we should probably decide which syntax we want to support

picoquery has 3:

we should probably set it to js i think, though the tests right now assert against the index-style syntax