search

chaijs / chai-json-schema

Chai plugin for JSON Schema v4
MIT License
75 stars 17 forks source link

Newer drafts of JSON Schema #63

Closed philsturgeon closed 5 years ago

philsturgeon commented 5 years ago

Hey there! JSON Schema draft 4 is pretty old now. The project is currently on draft 7, most tools around support at least draft 6.

Instead of using tv4 which is also only support draft 4, you could use another validator which is keeping up to date. For example, AJV has support for draft 4, 5, 6 and 7, so that should help, and it'll make updates easier in the future - especially as you have greenkeeper. It'll just let you know when a new version is out, with new drafts. 🙌

I don't use Chai enough to be able to justify working on this sadly, otherwise I'd be happy to turn this into a PR. If you have any questions I'm all ears. :)

edwardsmit commented 5 years ago

Hi @philsturgeon, I understand your lack of justification, and a lot of developers have the same problem. But such is the nature of Open Source, you're free to use it, and free to enhance it, but nobody is obliged to update the software. Anyone really needing such an update is free to create a PR.

edwardsmit commented 5 years ago

@philsturgeon Maybe https://github.com/up9cloud/chai-json-schema-ajv is a good alternative for you?

philsturgeon commented 5 years ago

I didn't say anything about obligation I wasn't chastising you! The point was that if you are interested there are newer libraries that can be used to help your tool support newer drafts. Do what you will with that information. :)

edwardsmit commented 5 years ago

@philsturgeon And I wasn't feeling chastised nor was I implying that you were. It was just a general thought of mine. I apologize if you felt attacked or offended in any way, that was not what I was trying to get across.

philsturgeon commented 5 years ago

Cool! I didn't I was just worried it came across wrong.

giphy