search

chaijs / chai-spies

Spies for Chai Assertion Library.
MIT License
132 stars 29 forks source link

Support `spy.on` with nullish prototype #118

Closed sebamarynissen closed 1 year ago

sebamarynissen commented 1 year ago

Fixes #117.

keithamus commented 1 year ago

Looks like travis CI is no longer working. I'll find some time to port to GitHub Actions and then get this merged, it might be a while though.

sebamarynissen commented 1 year ago

I can have a look at writing a GitHub action for it if you want, at least for running the tests on every PR. I don't have any experience with writing an action for publishing to npm, but I'll see what I can do. This should happen for every commit on master right? Is the version increased manually or should this happen in an action as well?

keithamus commented 1 year ago

I'd like to move Chai packages to a model I use at work, which is that we have a build step that simply runs npm it (e.g. here: https://github.com/github/relative-time-element/blob/main/.github/workflows/test.yml) and an action which runs whenever we publish a release via the GitHub UI, which publishes the package to the various registries (e.g. here: https://github.com/github/relative-time-element/blob/main/.github/workflows/publish.yml).

If you'd like to try and add those in a PR that'd be a great contribution that would be much appreciated!

sebamarynissen commented 1 year ago

@keithamus I created another PR that sets up GitHub actions for CI and publishing (#119). The PR was created off the master branch, so it does not include the changes from this PR yet. I propose to merge #119 first, and then we can merge this one, perhaps after a rebase.

sebamarynissen commented 1 year ago

@keithamus Is there anything that prevents releasing this on npm? I'm migrating a large codebase to Vue 3 at the moment and I'm using my own fork in package.json for it now

{
  "dependencies": {
    "chai-spies": "github:sebamarynissen/chai-spies#feature/nullish-prototype",
  }
}

but it obviously would be nicer to be able to just use chai-spies from npm.

Let me know if there's anything I can do to help if needed!

keithamus commented 1 year ago

@sebamarynissen v1.1.0 has been released. Thanks!