Closed stalniy closed 6 years ago
@stalniy as part of this I think we should also drop Node < 4 from the package.json, and no longer support it. Thoughts?
@keithamus this was done in #91
Yup 😆 just saw that and merged.
If you rebase this against master, the tests will pass and I will merge 👍
Done! lets merge this :)
@keithamus what do we need to do next to publish 1.0.0 on npm?
@stalniy could you please add some release notes to https://github.com/chaijs/chai-spies/releases/edit/untagged-c4a7ec2f780e17401aef and then hit Publish
- CI will take care of the rest.
Cool! @keithamus what do you think about merging #93 in 1.0.0 as well?
Ideally the format should be:
General release notes go here
# Breaking Changes
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)
# Bug Fixes
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)
# Docs
* <feat|fix>: Something breaking here #PRref (#IssueRef, @person-who-worked-on-it)
Sorry @keithamus , missed your last message. I will change the format. Do you use some tool to generate release notes?
Also npm i chai-spies@1.0.0
fails and npm i chai-spies@latest
installs 0.7.1 version. Are there some issues with CI pipeline or you decided to postpone release to fix release notes format?
@keithamus updated release notes according to recommended format, also added Bug Fixes
section. Could you please review draft, publish if everything is ok and make sure CI build updated version on npm?
I've gone ahead and manually published chai-spies@1.0.0 - it looks like it didnt publish on CI, I'll get around to fixing that later.