search

chaijs / chai

BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.
https://chaijs.github.io
MIT License
8.11k stars 696 forks source link

Allow deepEqual fonction to be configured globally #1551

Closed forty closed 9 months ago

forty commented 10 months ago

Tentative MR to allow configuring the deepEqual function globally, as discussed https://github.com/chaijs/chai/issues/1520

I have done things using a "flag", planning for the possibility of customizing the deepEqual function on a per assertion basis (but this is not implemented in this MR).

Please let me know what you think.

forty commented 10 months ago

Can I/Should I do the same MR on the 4.x branch? I think it would be useful for users (like me :grimacing: ) which are going to be stuck on this release because of the CommonJS drop

koddsson commented 9 months ago

Can I/Should I do the same MR on the 4.x branch? I think it would be useful for users (like me 😬 ) which are going to be stuck on this release because of the CommonJS drop

Yeah that could be good if you'd like it in the 4.x branch. I'm not sure how much support we can give to the 4.x branch once we release 5.x but we can at least merge PRs and publish the package.

forty commented 9 months ago

Awesome, thanks for the review & merge! I created the same MR for 4.x.x then https://github.com/chaijs/chai/pull/1553 (same diff as far I can can tell, except chai.js)