fix: removes `??` for node compat

chaijs / chai

BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.

https://chaijs.github.io

MIT License

8.11k stars 694 forks source link

Closed 43081j closed 7 months ago

43081j commented 7 months ago

We shipped syntax which is beyond our engine constraint. ?? is available in node 14 but 4.x is node 4 and above, while 5.x is node 12 and above.

This just dumbs it back down to || for now at least.

Fixes #1573

@koddsson @keithamus can we just catch 5.x up from 4.x when this lands? how do we deal with keeping them in sync, as 5 needs this too

chuphalashit19 commented 7 months ago

Hi, by when can we expect these changes to be merged and the issue to be resolved ?

keithamus commented 7 months ago