search

chaijs / chai

BDD / TDD assertion framework for node.js and the browser that can be paired with any testing framework.
https://chaijs.github.io
MIT License
8.1k stars 694 forks source link

chai-subset is unmaitained #1616

Open GustavoOS opened 3 months ago

GustavoOS commented 3 months ago

Hi

As in https://github.com/debitoor/chai-subset/issues/84 , chai-subset is unmaitained. The biggest contributor no longer has owner rights, but proposed to fork and maintain it. Is chaijs interest in owning the fork?

keithamus commented 3 months ago

Sure. Happy to add it to the org.

43081j commented 3 months ago

it may also be worth just building this functionality into chai itself, as some variant of includes

much of the logic in chai-subset exists in chai already, just not for this particular usage (e.g. recursively checking equality of nested types)

maybe this could just be achieved by some modifier of includes ("partial" or something, or includes.subset)

just a thought

keithamus commented 3 months ago

I am happy to do that, but we should only do that after transferring or at least discussing with the owners/maintainers.

eagleeye commented 3 months ago

Hey guys, I'm the main contributor to the chai-subset while I was working in Debitoor. I couldn't convince them to transfer ownership. I think it should be fine to add it into core functionality of chai of fork the repo and support the fork. The question is what is preferrable for the chaijs org?

keithamus commented 3 months ago

I think it would be great to clarify our intent to debitoor before moving forward. There's a strong chance if we fork the library into this org, or otherwise integrate changes into core, then the debitoor library will be rendered obsolete. I don't want that to come as a surprise to them. So I think a good next step is perhaps contacting them again, if you don't mind?

In terms of next steps beyond that, I think we can look at what it'll take to integrate directly into core (PRs welcome :wink:) but also I think having a fork (or ideally the source repo) under the chaijs org for archival purposes would be a good step also.

zetxek commented 3 months ago

Thanks for the convo and for letting us know! Both here and in https://github.com/debitoor/chai-subset/issues/84 :). 👋 Adrián from SumUp (formerly Debitoor) here.

While debitoor as an org is not active, it's now part of @sumup :) - and while we do maintain some open source software (https://github.com/sumup-oss), as you have seen, chai-subset (https://github.com/debitoor/chai-subset/issues) is not among the well-kept ones.

Feel free to fork and integrate the codebase into chaijs :)

For the ownership transfer I'd have to look into the process to transfer it (might take longer). With the matter of the original repo going obsolete - maybe we could add a notice to the readme and mark it as deprecated? (given that the last commit is from 2017, 7 years ago)

eagleeye commented 3 months ago

Cool, I'll prepare a PR to chai in the nearest future. I believe that chai-subset is a good fit for core functionality of chai.

koddsson commented 3 months ago

I hope you don't mind that I hacked on this quickly while waiting at a airport. I tried to make sure that the history was preserved in doing this.