search

chaijs / chaijs.github.io

The chaijs.com website source code. Contributions welcome.
http://chaijs.github.io
49 stars 71 forks source link

Correct typo in banner.html #142

Closed EJLearner closed 7 years ago

EJLearner commented 7 years ago

Just a small fix for a typo that has been on the front page of the chaijs.com website for a while.

Missing the word "to" as shown by the screen shot:

image

lucasfcosta commented 7 years ago

LGTM @keithamus what do you think about this? Apparently PRs don't have permissions to run on Travis and that's why the build is failing.

EJLearner commented 7 years ago

I'm assuming that it is something that I didn't do right. This is my FIRST github PR and I was planning to take some time to figure out why I'm getting authentication failures but haven't had the time yet.

lucasfcosta commented 7 years ago

@EJLearner that makes sense. Maybe this StackOverflow question could help you. However, I still don't think this problem is exactly related to that since other PR builds have been failing before, as you can see here. If you need any help with Git or GitHub shoot me an email and I can help you get things going. It's great to have new people around, good luck on your journey buddy 😄

keithamus commented 7 years ago

Hey @EJLearner thanks for the PR.

The build is failing because I didn't set it up properly for PRs. The authentication failure is because it expects to run in the master branch, don't worry about that. Let's just get this merged in anyway.

LGTM - @lucasfcosta?

lucasfcosta commented 7 years ago

LGTM too. Thanks for the work @EJLearner :smile: