search

chaijs / chaijs.github.io

The chaijs.com website source code. Contributions welcome.
http://chaijs.github.io
49 stars 71 forks source link

`length` as assertion => `lengthOf` #143

Closed shvaikalesh closed 7 years ago

shvaikalesh commented 7 years ago

Related to https://github.com/chaijs/chai/issues/684

keithamus commented 7 years ago

👍 LGTM

lucasfcosta commented 7 years ago

LGTM too! Since @meeber still had to think about it on Chai's main repo I'll leave this open for him to merge if he feels confortable with it.

shvaikalesh commented 7 years ago

So with https://github.com/chaijs/chai/pull/897 we favor lengthOf over length for cross-env consistency. I believe this change is still relevant.

keithamus commented 7 years ago

Agreed. Let's get CI agreeing before we merge though 😉

shvaikalesh commented 7 years ago

Seems like auth issues:

remote: Anonymous access to chaijs/chai-docs.git denied.
fatal: Authentication failed for 'https://@github.com/chaijs/chai-docs/'
keithamus commented 7 years ago

in which case merged 😄