search

chaijs / chaijs.github.io

The chaijs.com website source code. Contributions welcome.
http://chaijs.github.io
49 stars 71 forks source link

Delist or update sinon-chai plugins (404) #173

Closed Ryuno-Ki closed 6 years ago

Ryuno-Ki commented 6 years ago

When visiting http://www.chaijs.com/plugins/@cypress/sinon-chai/ or http://www.chaijs.com/plugins/@slightlytyler/sinon-chai/ I see a 404.

The corresponding markdown files can be found here: https://github.com/chaijs/chaijs.github.io/blob/8cba8fe81a3c0cf2c9679691faed63d2ab4a4b81/plugins/_cypress_sinon_chai.md and https://github.com/chaijs/chaijs.github.io/blob/8cba8fe81a3c0cf2c9679691faed63d2ab4a4b81/plugins/_slightlytyler_sinon_chai.md.

Either @domenic and/or @slightlytyler updates the submission (see code in https://github.com/domenic/sinon-chai resp. https://github.com/slightlytyler/sinon-chai) or those plugins should be removed.

slightlytyler commented 6 years ago

You should remove mine. My fork was a hack I needed for some reason. Not sure why mine is included in the docs at all

keithamus commented 6 years ago

We scrape npm for the plugin listing. We can manually blacklist plugins here: https://github.com/chaijs/chaijs.github.io/blob/master/_scripts/banned_plugins.js. I'll add these to the list of blacklisted plugins.

keithamus commented 6 years ago

Should be fixed in https://github.com/chaijs/chaijs.github.io/commit/24af0083ee0ec7bafe117fec4e9c09dd4e567575