Closed shivamsngh closed 5 years ago
Nice work @shivamsngh!
We should probably update all asset references to {{site.github.url}}
.
@keithamus, is it necessary to keep using {{site.github.url}}
instead of just using a relative path? For example, using <script src="/js/main.js"></script>
instead of using <script src="{{ "/js/main.js" | prepend: site.github.url | replace: 'http://', '//' }}"></script>
?
I'm happy to use absolute paths. @shivamsngh are you happy to make those changes?
Sure, I will make those chages and create the pull request
Sure, I will make those chages and create the pull request
@keithamus @aaronsofaly I have pushed the changes to original pull request. Please review and merge.
thanks for working on this @shivamsngh! Thanks for the assist @aaronsofaly
Mixed content because of secure https protocol is stopping the scripts and css to load and render.