chaijs / chaijs.github.io

The chaijs.com website source code. Contributions welcome.
http://chaijs.github.io
49 stars 71 forks source link

Mixed content because of secure https protocol #177

Closed shivamsngh closed 5 years ago

shivamsngh commented 5 years ago

Mixed content because of secure https protocol is stopping the scripts and css to load and render.

aaronsofaly commented 5 years ago

Nice work @shivamsngh!

We should probably update all asset references to {{site.github.url}}.

@keithamus, is it necessary to keep using {{site.github.url}} instead of just using a relative path? For example, using <script src="/js/main.js"></script> instead of using <script src="{{ "/js/main.js" | prepend: site.github.url | replace: 'http://', '//' }}"></script>?

keithamus commented 5 years ago

I'm happy to use absolute paths. @shivamsngh are you happy to make those changes?

shivamsngh commented 5 years ago

Sure, I will make those chages and create the pull request

shivamsngh commented 5 years ago

Sure, I will make those chages and create the pull request

@keithamus @aaronsofaly I have pushed the changes to original pull request. Please review and merge.

keithamus commented 5 years ago

thanks for working on this @shivamsngh! Thanks for the assist @aaronsofaly