search

chaijs / sinon-chai

Extends Chai with assertions for the Sinon.JS mocking framework.
Other
1.09k stars 108 forks source link

Add support for sinon v5 #122

Closed dostu closed 6 years ago

dostu commented 6 years ago

Closes #120

joovel commented 6 years ago

LGTM

voxpelli commented 6 years ago

This should update the Travis-definition as well, see how I did it in my PR: https://github.com/domenic/sinon-chai/pull/125

Else it won't test on Sinon 5 there, and it should preferably test with both Sinon 5 and Sinon 4

I'll close my PR in favor of this one though, sorry for not noticing it before I opened mine 🙈

dostu commented 6 years ago

Thanks for your feedback, I've updated my PR.

davesag commented 6 years ago

Looking forward to this being merged so I can finally update sinon in my project to v5

dostu commented 6 years ago

@domenic, please take a look at this. It would be great if we could merge it and cut a new version.

domenic commented 6 years ago

Sinon-Chai is a spare-time project; I will hopefully have time to work on it this weekend, but even if I don't, please refrain from further +1 comments.

davesag commented 6 years ago

thanks @domenic — please let us know when this hits NPM. Very eager to upgrade sinon.

domenic commented 6 years ago

Dang, I did indeed forget to npm publish. Done now.