search

chaijs / sinon-chai

Extends Chai with assertions for the Sinon.JS mocking framework.
Other
1.09k stars 108 forks source link

npm-check fails due to peer dependency of sinon < 7.0.0 #132

Closed stevegoossens closed 5 years ago

stevegoossens commented 6 years ago

Sinon 7.0.0 looks like it was released 3 days ago.

sinon 6.3.5 installed

npm-check now fails, e.g.

sinon   😎  MAJOR UP  Major update available. https://sinonjs.org/
                     npm install --save-dev sinon@7.0.0 to go from 6.3.5 to 7.0.0

Use npm-check -u for interactive update.
npm ERR! code ELIFECYCLE
npm ERR! errno 1

sinon 7.0.0 installed

installing sinon@7.0.0 causes npm test failure due to:

npm WARN sinon-chai@3.2.0 requires a peer of sinon@>=4.0.0 <7.0.0 but none is installed. You must install peer dependencies yourself.
pkuczynski commented 6 years ago

This would be fixed by #131

simondel commented 5 years ago

I'm in contact with Domenic to transfer ownership to me so PR's can be merged and released.

simondel commented 5 years ago

I'll create a release today.

simondel commented 5 years ago

sinon-chai@3.3.0 has been released 🎉