chaimPaneth / react-native-jw-media-player

React-Native Android/iOS bridge for JWPlayer SDK (https://www.jwplayer.com/)
MIT License
197 stars 92 forks source link

allow setting multiple values for hideUiGroup #284

Closed nateshmbhat closed 1 year ago

nateshmbhat commented 1 year ago

I want to hide both casting_menu and playback_submenu in android. but right now hideUiGroup only takes single value. please add support to hide multiple items.

purhaps you can merge this feature with setVisibility method to work for both ios and android

razorRun commented 1 year ago

@nateshmbhat thanks for the Fix, however I tried this and doesn't seems to work for me. Can you maybe share a sample code for this ?

@chaimPaneth can we kindly get this into your list.. also maybe a release with this and iOS visibility..

nateshmbhat commented 1 year ago

@razorRun heres the sample code

<JWPlayer
        config={{
          ...
          hideUIGroups: ['casting_menu', 'settings_menu']
}}
chaimPaneth commented 1 year ago

Merged

razorRun commented 1 year ago

💪