Fullscreen Events not working in latest build

chaimPaneth / react-native-jw-media-player

React-Native Android/iOS bridge for JWPlayer SDK (https://www.jwplayer.com/)

MIT License

190 stars 91 forks source link

Fullscreen Events not working in latest build #309

Closed ddolheguy closed 8 months ago

ddolheguy commented 1 year ago

Using the latest build, events such as onFullScreen, onFullScreenExit and onFullScreenRequested are not firing on iOS.

I've debugged this and in the RNJWPlayerViewController.m file, the JWFullScreenViewController events seem not the be firing as expected. For example, setting a debugger on the below fails to fire when going full screen.

(JWFullScreenViewController _Nullable)playerViewControllerWillGoFullScreen:(JWPlayerViewController _Nonnull)controller { if (_parentView.onFullScreenRequested) { _parentView.onFullScreenRequested(@{}); } return nil; } `

grigdodon commented 1 year ago

hey. were they working for you in the previous versions? I am stuck on 0.2.34 because the onFullScreenExit event is not being fired.

grigdodon commented 1 year ago

hey @chaimPaneth sorry to bother you. any chance you can give an update on this? Maybe the fullscreen events work now in a different way than the documentation says? any help will be highly appreciated! thank you!

I can't manage to have the full screen events work from version 0.2.34 onwards. Thank you!

chaimPaneth commented 9 months ago

Hey guys is this working for you on the latest version.

grigdodon commented 8 months ago

Hey guys is this working for you on the latest version.

yes. thank you for sorting this out!

not related to this issue, but it looks like casting on android still not works. any chance to have the option to not add google cast by default in the library so we can control the casting or maybe the issue can be fixed?

chaimPaneth commented 8 months ago

Thanks @grigdodon I'm closing this and will check and update about casting here https://github.com/chaimPaneth/react-native-jw-media-player/issues/314