chaimPaneth / react-native-jw-media-player

React-Native Android/iOS bridge for JWPlayer SDK (https://www.jwplayer.com/)
MIT License
193 stars 92 forks source link

fix: update types for adSchedule #322

Closed crwhite21 closed 10 months ago

crwhite21 commented 11 months ago

Updated the TypeScript definition types for Advertising.adSchedule and PlaylistItem.adSchedule to match the prop-types shape here and here.

chaimPaneth commented 10 months ago

Hi @crwhite21

I will also update the name to plural adSchedules so I'm closing the PR and will commit this change to develop.

chaimPaneth commented 10 months ago

On second thought natively in JW SDK it's also called adSchedule singular as an array so I'll merge this