chaimPaneth / react-native-jw-media-player

React-Native Android/iOS bridge for JWPlayer SDK (https://www.jwplayer.com/)
MIT License
193 stars 92 forks source link

Question about modifying RNJWPlayerView on node_modules to try something out #329

Closed felire closed 9 months ago

felire commented 9 months ago

Hey! I am trying to add new fields here:

- (void)jwplayer:(id _Nonnull)player adEvent:(JWAdEvent * _Nonnull)event {
    if (self.onAdEvent) {
        self.onAdEvent(@{@"client": @(event.client), @"type": @(event.type), @"adTitle": @(event.type)});
    }
}

But, whenever I want to try it out, adTitle is always undefined. Is there any other place where I should update it, or something else I have to touch in order to see that change? I am updating that from the RNJWPlayerView.m file and rebuilding the entire app after that.

felire commented 9 months ago

adTitle was coming inside nativeEvent field on the js side.