search

chainapsis / keplr-chain-registry

Protocol for Integrating Non-Native Chains to Keplr
https://chains.keplr.app
Other
335 stars 502 forks source link

update composable name and prefix #608

Closed JafarAz closed 5 months ago

JafarAz commented 5 months ago

This PR introduces three core changes:

  1. Update Composable chain name to Picasso
  2. Update centauri prefix to pica
  3. Addition of assets that are being bridged from Ethereum via Picasso

If all passes checked, Please do not merge this PR until Wednesday as that is when the chain will be upgraded and the prefix will be changed.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 11:41pm
editaahn commented 5 months ago

Hi. Please make sure the image sizes are 256*256px.

JafarAz commented 5 months ago

yeah apologies, took a while but updated sizes @editaahn

JafarAz commented 5 months ago

Would it be possible to merge this around 17:00 UTC? That is when the chain upgrade takes place

editaahn commented 5 months ago

Would it be okay to merge it at 15:00 UTC? 17:00 UTC is 2:00 KST, too early for Keplr dev team's timezone.

editaahn commented 5 months ago

We've concluded that it's better to merge it after the chain upgrade and internal testing on Keplr, due to its prefix change. Would it be fine if I approve the merge 8-10 hours later than the upgrade?

JafarAz commented 5 months ago

@editaahn 15:00 UTC works, we've tested this change on testnet in my previous PR and it worked smoothly afterwards.

editaahn commented 5 months ago

@JafarAz Apologies for any inconvenience, but our team has decided to conduct a test 'after the chain upgrade' just in case. The earliest feasible time for this would be around 00:00 UTC (9:00 KST). Additionally, would you mind sending a small amount of tokens to centauri1xs55snr6lxsalaqrwc63cxlmgn437zzvlg9z02 for our test?

JafarAz commented 5 months ago

I've sent you the PICA, the chain upgrade will occur in under an hour. Would really appreciate if you could merge the PR as it will then mean that Keplr will be unusable for users with our network for 8 hours

editaahn commented 5 months ago

Sorry for making you wait due to the timezone issue. The PR was merged, and the test was done.

JafarAz commented 5 months ago

No worries @editaahn

Appreciate it

One question, what is the best solution to providing an RPC to the registry? the current one from lavender seems to be hitting the rate limit often