Add Self Chain (SLF) - Githubissues

chainapsis / keplr-chain-registry

Protocol for Integrating Non-Native Chains to Keplr

https://chains.keplr.app

Other

335 stars 502 forks source link

Add Self Chain (SLF) #669

Closed philiparthurmoore closed 4 months ago

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
keplr-chain-registry	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 5:01am

editaahn commented 4 months ago

Hi!

The image file/directory names have to follow the chain identifier. (You can find the details on its README)
Please make sure coinGeckoId is available in CoinGecko website.

philiparthurmoore commented 4 months ago

Hi @editaahn - we have made the necessary modifications. Please check. Thank you!

editaahn commented 4 months ago

Since Keplr needs coinGeckoId for fetching prices and Coin Gecko right now seems it doesn't manage Self Chain token price, would you mind registering other information only, except for coinGeckoId?

philiparthurmoore commented 4 months ago

Since Keplr needs coinGeckoId for fetching prices and Coin Gecko right now seems it doesn't manage Self Chain token price, would you mind registering other information only, except for coinGeckoId?

Absolutely @editaahn - we've removed the coinGeckoId stuff for now. We're migrating from FRONT to SLF so once that price feed becomes available we can add it into Keplr JSON. For now everything else looks good to merge, I hope.

Let me know - thanks so much.

editaahn commented 4 months ago

Thank you! Additonally, the JSON name and image directory name should be self.

philiparthurmoore commented 4 months ago

Thank you! Additonally, the JSON name and image directory name should be self.

Done. 👍🏽