chainapsis / keplr-wallet

The most powerful wallet for the Cosmos ecosystem and the Interchain
https://www.keplr.app
Other
766 stars 457 forks source link

Wallet loses focus and state if clicking away (e.g. copy/paste address/memo) #67

Closed cryptotester closed 2 years ago

cryptotester commented 3 years ago

Steps to reproduce:

Result:

I see the initial keplr screen showing my total balance and send / deposit buttons.

Expected result:

I was expecting to see the screen I was filling a few seconds before, to paste the memo and complete the transaction.

Like this it's unusable, if I can't even paste a memo after pasting an address it's very dangerous. I already lost funds in the past by manually writing a memo instead of copy/pasting it and I don't want to risk again the same kind of loss.

MetaMask solves this problem by having an "expand" button, which opens metamask in a fullscreen tab. If you could do the same it would be awesome.

Possible fix 1: remember the last state, if somebody was pasting an address, leave that screen so the user comes back and can continue the transaction by pasting memo, pasting amount etc.

Possible fix 2: Check the Terra Station extension (for the mirror protocol) I reported the same issue and they just fixed it by allowing to right click on "Terra Station" at the top once the popup is open to "open in a new tab". They didn't even make a design for the full screen, it's the same size. I guess it was the fastest fix.

Since possible fix 1 needs more work, maybe possible fix 2 is the easiest fastest way to fix this (I still believe do it like MetaMask would be the best and most elegant solution).

Thank you.

cryptotester commented 3 years ago

Guys PLEASE fix this, it's not just an "anhancement". I mean you even grayed out "Options" if I right click on keplr from my chrome extensions. Other extensions at least allow a user to right click on options and open a new tab, then rename options.html to app.html.

But guys come on just add a button somewhere at the top to simply open keplr in a new tab.

I reported exactly this same issue for terra station and they added the button. I reported this to xdefi wallet, they added the button.

I'm not asking the moon, just to open this extension in a new tab, should be like 10 minutes of work...

User story: try to go to secret network > tokens list > add a new token > try to import an existing key. You paste the key you copied from another window, now you still need to paste also the token address... you go to another window to copy the token address, you go back to keplr and BOOM it lost focus and you can't paste it.

Just this simple scenario shows you how important is to allow to open keplr in a new tab.

Thank you

delivan commented 2 years ago

Hi @cryptotester

we fixed it by adding the detach button to the top right of send page. This fix has been published to v0.9.6. Let me know that the issue is resolved. thank you for reporting.

cryptotester commented 2 years ago

Hi @cryptotester

we fixed it by adding the detach button to the top right of send page. This fix has been published to v0.9.6. Let me know that the issue is resolved. thank you for reporting.

Hi, thank you, but it's still buggy. Try e.g. the following:

Issue/bug: You can paste only one text, as soon as you move to another window, and come back, keplr loses focus and you won't be able to accomplish the task.

Expected behavior: either it won't lose focus, or it's possible to expand to a new tab or detach like for the previous fix.

Please consider to make a more generic solution as I initiallysuggested? I mean to allow to use the extension in a new tab (like metamask, terra station, xdefi etc.). Else I'm afraid it may occur soon or later the same issue in another screen in another case, it's quite difficult to test/cover all cases...

Thank you and best regards.

cryptotester commented 2 years ago

@delivan can you please consider to re-open this? (read my comment above)