chainbase-labs / manuscript-core

Apache License 2.0
133 stars 30 forks source link

Port Mapping Issue: Manuscript Deployment Defaults to localhost:0 #60

Closed anishkandel closed 6 days ago

anishkandel commented 1 week ago

Self Checks

Environment

OS: Ubuntu 20.04 / 22.04 Manuscript CLI Version: Latest (as of date) Docker Version: e.g., Docker 20.10.21 Compose Version: e.g., Docker Compose v2.20.2

Steps to reproduce

  1. Install Manuscript CLI using the command curl -fsSL https://github.com/chainbase-labs/manuscript-core/raw/main/install.sh | bash

  2. Deploy a manuscript using the command:

manuscript-cli deploy /path/to/manuscript.yaml --env=local

  1. Observe the deployment output: You can now access your manuscript at http://localhost:0.

  2. Inspect the docker-compose.yaml file to find the port mapping as 0:8080. (All other ports to 0)

✔️ Expected Behavior

The manuscript should be accessible at a valid port, e.g., http://localhost:8080. The docker-compose.yaml file should explicitly bind ports like this:

ports:
  - "8080:8080"

❌ Actual Behavior

When deploying the Manuscript CLI using the provided installation script and Docker Compose, the output indicates: You can now access your manuscript at http://localhost:0.

The port is incorrectly set to 0, making the service inaccessible. This appears to be a port mapping issue in the generated docker-compose.yaml file. The file includes a mapping like 0:8080, which assigns a random port instead of explicitly binding to a standard port (e.g., 8080:8080).

Actual Behavior: The deployment defaults to http://localhost:0, and the port binding in the docker-compose.yaml file is incorrect (0:8080).

KagemniKarimu commented 1 week ago

❤️ Thank you @anishkandel for reporting this bug 🐛 !

@Liquidwe

I can confirm I had this same issue during our Discord Community Code session on 11/20/2024.

💻 Environment Details

    Linux: fedora-workstation 6.11.8-300.fc41.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Nov 14 20:37:39 UTC 2024 x86_64 GNU/Linux
    Docker: Docker version 27.3.1, build ce12230
    Manuscript-core: Latest (as of 11/20/2024)
    Docker Desktop: 4.36.0