search

chainbound / bolt

Bolt: permissionless out-of-protocol proposer commitments.
https://chainbound.github.io/bolt-docs/
MIT License
27 stars 5 forks source link

feat(sidecar): configurable `ValidatorIndex` #101

Closed namn-grg closed 4 days ago

namn-grg commented 6 days ago

This PR adds CLI option to pass validator_index as comma-separated values i.e. --validator-index "1,2,3,4"

fixes #57

namn-grg commented 5 days ago

Looks good! Left a few nits. Just one note: have you been able to test the CLI option? I don't think that --validator-index 1, 3, 4 would work because of the spaces after each comma, but I'm not sure.

Also, it would be nice to support specifying an array with the [2,5] notation specified in the issue. One way to do this could be to check if the flag value starts with [ in the parse_validator_indexes function, but maybe there are other ways too

@merklefruit as discussed since the brackets are an issue, I have changed it to be compatible with quotation marks i.e. --validator-index "1,2,3,4"