Should this not be an empty string instead of 0x00 as it was in the example from earlier in the lesson?

chaincodelabs / bitcoin-tx-tutorial

A technical tutorial for understanding how bitcoin transactions are created and signed

105 stars 42 forks source link

Should this not be an empty string instead of 0x00 as it was in the example from earlier in the lesson? #16

Closed gimballock closed 8 months ago

gimballock commented 1 year ago

https://github.com/chaincodelabs/bitcoin-tx-tutorial/blob/d842ebfc0608a890c483ea53f59f9bdd01e042f9/chapter1-legacy/p2pkh.ipynb#L847

DariusParvin commented 1 year ago

Hi @gimballock, great observation. Yes that is an error and should be an empty string. If you like you can open a PR to correct it (and anywhere else if you see it), or i'll get to it this weekend. Thanks!

DariusParvin commented 8 months ago

fixed in https://github.com/chaincodelabs/bitcoin-tx-tutorial/pull/17