search

chaincodelabs / bitcoinperf

High-level performance monitoring framework for Bitcoin Core
https://bitcoinperf.com
52 stars 16 forks source link

Replace deprecated rpcuser with cookie auth #22

Closed maflcko closed 6 years ago

maflcko commented 6 years ago

Commit a1b8df71a199c591b3b2c2b40f50cdc712c9d has a typo "rpcusername", which would likely cause the syncing node to fall back to cookie auth.

It seems easier to me to just call bitcoin-cli -datadir=${workdir}/bitcoin/data -rpcport=9004 instead of specifying the rpcuser and pass. Note that they are also identical for the syncing and synced peer, which might lead to issues.

maflcko commented 6 years ago

untested. Would probably have to restart the synced node for it to be effective.

jamesob commented 6 years ago

Much better, thanks. I pushed a small change removing some now unused variables.