search

chaincodelabs / bitcoinperf

High-level performance monitoring framework for Bitcoin Core
https://bitcoinperf.com
52 stars 16 forks source link

Cache simplification & fixes #57

Closed jamesob closed 3 years ago

jamesob commented 3 years ago

Instead of trying to be smart with selective caching of the contents of bitcoin/ (and subsequently introducing exceptions thrown in production), just cache the whole darn directory. It's a few hundred megabytes, but on these environments nobody should be worrying about that amount of disk space

During development of benchula (i.e. emphasis on the bench-pr functionality), the "bench a single branch" path sort of fell behind, so there are a few miscellaneous fixes here intended to get bitcoinperf.com back into fighting shape.

jamesob commented 3 years ago

Tested locally in the docker environment. I'll fix up unittests in a separate PR (assuming they're even failing).