Closed amovfx closed 2 years ago
Hi thanks for your close review. You are indeed correct there's a typo there. However I did mean to prepend configure and autogen.sh with a ./
, but it should have looked like this in both cases, instead of just for configure:
.././autogen.sh
.././configure
This matches usual syntax for running scripts without requiring your shell to search your entire PATH. However in this case, as we are already specifying the path to the script up a directory, the additional ./
is unnecessary (although it does still work for me) and so your PR is a nice simplification and fix in one, thanks.
Hey Jonas, A couple of reasons for this pull request.
I followed the instructions on the build path twice to double check after pulling down the bitcoin core repo. My directory contents.
I noticed that autogen and configure don't start with a '.'. So while in the build directory '../.autogen.sh' does not exist. This is the same for configure.
Perhaps this code snippet is outdated?
Can anyone reproduce the following?
Clean current source dir in case it was already configured
make distclean
Make new build dir
mkdir build && cd build
Run normal build sequence with amended path
.././autogen.sh .././configure --your-normal-options-here ../make -j
nproc
../make check