chaincodelabs / onboarding-to-bitcoin-core

The missing onboarding guide to Bitcoin Core
https://bitcoincore.academy
91 stars 37 forks source link

Mention `stress test` in `Tests overview` #42

Closed brunoerg closed 1 year ago

brunoerg commented 2 years ago

In Tests overview, it would be great to short mention we have stress test in Core? It's into the functional test (to not rewrite same code) but we can consider it a different category of test.

See: https://github.com/bitcoin/bitcoin/commit/d9803f7a0a33688f7429cf10384244f4770851ca

willcl-ark commented 2 years ago

Hello Bruno, thanks for the feedback.

I don't think I quite see how this test is different from many of the other feature_*.py tests? We have e.g. abortnode, dbcrash, shutdown etc. which all might be considered similar, perhaps you could explain a little further?

I think that personally if I heard that we had a "stress test" I would take it to mean that we have a test which exercised many of the potential DoS vectors to try and stress the CPU/RAM/Disk and check that the node doesn't fall over (although I fully take the point that the author of that PR named the commit " test: add stress tests for initialization ") 😄

brunoerg commented 1 year ago

Hey, sorry for the late reply!

I think you're right, this specific test is not sooo different compared to other ones we have in feature_*.py, just thought interesting to short mention it because there were some new contributors I talked about it that didn't know we could have into our functional tests this kind of tests (e.g. stressing initialization by disturbing files, etc.).

willcl-ark commented 1 year ago

Hmmm, I agree with you actually!

Do you think something like this commit would cover it adequately enough? (and, if you'd prefer to submit the PR yourself, then please feel free!)

brunoerg commented 1 year ago

Yes, that commit sounds good.