search

chaincodelabs / onboarding-to-bitcoin-core

The missing onboarding guide to Bitcoin Core
https://bitcoincore.academy
91 stars 37 forks source link

Add a glossary of common terms #52

Closed adam2k closed 1 year ago

adam2k commented 1 year ago

Resolves https://github.com/chaincodelabs/onboarding-to-bitcoin-core/issues/50

Add a glossary of common terms after the appendix.

willcl-ark commented 1 year ago

Hey Adam, this looks like a great start to this section!

I added a second commit with some minor fixups which I noticed on a first read. Perhaps you could check if you are happy with them?

I pushed a version with these two commits to https://obc.256k1.dev/#_glossary already, so you can see what it looks like live (which you can also do locally by running asciidoctor -r asciidoctor-diagram --verbose --trace index.adoc; open index.html FYI).

Edit: I know the diff looks large, but really most of it was just newlines (one sentence per line).

willcl-ark commented 1 year ago

Just fixed (my own) tab indentations :)

adam2k commented 1 year ago

@willcl-ark the changes look good! I was able to see them in the git diff, but I didn't see them on the website. Maybe something is still cached for me or you reverted those changes? I tried in two different browsers and I couldn't see the glossary.

willcl-ark commented 1 year ago

Try refreshing the browser cache (ctrl + shift + r or perhaps cmd+shift+r?)

willcl-ark commented 1 year ago

Merged in https://github.com/chaincodelabs/onboarding-to-bitcoin-core/commit/e9538fc43caa6a76d62be513c3af0abbb714a024