MasternodeList::updateMyMasternodeInfo parameter not checked

[yajiedesign]

the parameter infoMn is not check.when mn not run.it is null.it will be crash.

[brakmic]

Please be more precise. Your issue is also not very readable. Do not expect others to guess your thoughts.

Thanks!

[chaincoin-legacy]

It looks like it is only called when there is a masternode config:

masternodelist.cpp line 239:

BOOST_FOREACH(CMasternodeConfig::CMasternodeEntry mne, masternodeConfig.getEntries()) {

... updateMyMasternodeInfo(QString::fromStdString(mne.getAlias()), QString::fromStdString(mne.getIp()), infoMn); }

[yajiedesign]

https://github.com/chaincoin/chaincoin/blob/master/src/qt/masternodelist.cpp#L186 infoMn some time is null.please check it.

[yajiedesign]

https://github.com/chaincoin/chaincoin/blob/master/src/qt/masternodelist.cpp#L247 this line CMasternode *infoMn = mnodeman.Find(txin); not always find some item.

[brakmic]

Could this be related to the sudden core dump we experienced after my pull request. I am only speculating here as I'm not into QT.

[yajiedesign]

it cause core dump.

[brakmic]

@yajiedesign yeah, it core dumped but your core dump could be another one. I am still speculating here. :)

[brakmic]

And btw. I use a masternode.conf.

[chaincoin-legacy]

A fix for this will follow.

[chaincoin-legacy]

Included in this commit

https://github.com/chaincoin/chaincoin/commit/7b8ae63c5c5e9fe73b4edb9dd1944fcfcf721f57

[brakmic]

I'd like to thank you @yajiedesign for helping us find this bug. 👍 ❤️

[yajiedesign]

ok.thanks