chainer / chainer-chemistry

Chainer Chemistry: A Library for Deep Learning in Biology and Chemistry

MIT License

632 stars 132 forks source link

Arrange `links` modules #270

Closed natsukium closed 5 years ago

natsukium commented 5 years ago

I arrange links submodule

[x] ~move models to links/model~
[x] make dirs, links/connection and links/normalization
[x] divide model modules(NFP, GGNN and so on) into submodules(conv, readout)

codecov-io commented 5 years ago

Codecov Report

Merging #270 into master will increase coverage by 0.41%. The diff coverage is 90.55%.

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   83.25%   83.67%   +0.41%     
==========================================
  Files         147      165      +18     
  Lines        7095     7632     +537     
==========================================
+ Hits         5907     6386     +479     
- Misses       1188     1246      +58

corochann commented 5 years ago

please keep models directory as is.

corochann commented 5 years ago

For the travis test, could you merge latest master branch.

https://github.com/pfnet-research/chainer-chemistry/pull/280 This should fix it. ( _device attribute in classifier, regressor is used in chainer 6 internally)

natsukium commented 5 years ago

I have fixed some problems. Please confirm.

corochann commented 5 years ago

LGTM, thank you!