chainer / chainer-chemistry

Chainer Chemistry: A Library for Deep Learning in Biology and Chemistry

MIT License

629 stars 130 forks source link

Fix ggnn #292

Closed natsukium closed 5 years ago

natsukium commented 5 years ago

I have refactored GGNN model which is able to handle args; step, concat_hidden and weight_tying. Due to this, GGNNUpdate and GGNNReadout modules have no state of network.

codecov-io commented 5 years ago

Codecov Report

Merging #292 into master will decrease coverage by 0.01%. The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   83.67%   83.66%   -0.02%     
==========================================
  Files         165      165              
  Lines        7632     7627       -5     
==========================================
- Hits         6386     6381       -5     
  Misses       1246     1246

natsukium commented 5 years ago

I improve GGNN based on comment without activation. Could you check it please?

corochann commented 5 years ago

LGTM, let me separate activation function in other PR.