chainer / chainer-chemistry

Chainer Chemistry: A Library for Deep Learning in Biology and Chemistry

MIT License

629 stars 130 forks source link

Nfppreprocessor return is real node #298

Closed corochann closed 5 years ago

corochann commented 5 years ago

Please merge after https://github.com/pfnet-research/chainer-chemistry/pull/296

corochann commented 5 years ago

This PR will change the NFPPreprocessor's behavior to output is_real_node. I will proceed to the same thing for GGNNPreprocessor after PR merged.

codecov-io commented 5 years ago

Codecov Report

Merging #298 into master will increase coverage by 0.08%. The diff coverage is 98.3%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   83.64%   83.73%   +0.08%     
==========================================
  Files         174      174              
  Lines        7987     8030      +43     
==========================================
+ Hits         6681     6724      +43     
  Misses       1306     1306

corochann commented 5 years ago

example test ok.

corochann commented 5 years ago

-> https://github.com/pfnet-research/chainer-chemistry/pull/311