chainer / chainer-chemistry

Chainer Chemistry: A Library for Deep Learning in Biology and Chemistry

MIT License

622 stars 129 forks source link

Fix the type of return value from R2 Score Evaluator #339

Closed mottodora closed 5 years ago

natsukium commented 5 years ago

Could you fix test_r2_score_evaluator.py too? Thank you for fixing my mistake.

natsukium commented 5 years ago

These indices is unnecessary.

https://github.com/pfnet-research/chainer-chemistry/blob/6de82de4cafd38a9826e68771432bff6ab01edc5/tests/training_tests/extensions_tests/test_r2_score_evaluator.py#L96

mottodora commented 5 years ago

Fixed.

codecov-io commented 5 years ago

Codecov Report

Merging #339 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files         199      199           
  Lines        9069     9069           
=======================================
  Hits         7294     7294           
  Misses       1775     1775