chainer / chainer-chemistry

Chainer Chemistry: A Library for Deep Learning in Biology and Chemistry

MIT License

622 stars 129 forks source link

Refactoring Graph Warp Module #340

Closed mottodora closed 5 years ago

mottodora commented 5 years ago

Resolve #329

[x] Add unit test of preprocesor
[x] Refactor preprocessor
[x] Add unit test of GWM model
[x] Refactor GWM model

mottodora commented 5 years ago

I finish implementation. Please review.

codecov-io commented 5 years ago

Codecov Report

Merging #340 into master will increase coverage by 1.29%. The diff coverage is 94.96%.

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   81.65%   82.95%   +1.29%     
==========================================
  Files         210      211       +1     
  Lines        9647     9813     +166     
==========================================
+ Hits         7877     8140     +263     
+ Misses       1770     1673      -97

corochann commented 5 years ago

Can you update code? @mottodora

corochann commented 5 years ago

I will take over.