chainer / chainer-chemistry

Chainer Chemistry: A Library for Deep Learning in Biology and Chemistry

MIT License

622 stars 129 forks source link

Reduce container image size #365

Closed zaltoprofen closed 5 years ago

zaltoprofen commented 5 years ago

File creations and deletions moved to same layer to reduce size. Achieved the image size reduction of 270MB.

$ docker image ls |grep chainer-chemistry
chainer-chemistry           modified            1234567890        18 minutes ago      4.59GB
chainer-chemistry           latest              0987654321        About an hour ago   4.86GB

codecov-io commented 5 years ago

Codecov Report

Merging #365 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files         219      219           
  Lines       10324    10324           
=======================================
  Hits         8661     8661           
  Misses       1663     1663

cks-coil commented 5 years ago

LGTM!

corochann commented 5 years ago

Thank you for PR & Review!!