chainer / chainer-chemistry

Chainer Chemistry: A Library for Deep Learning in Biology and Chemistry

MIT License

629 stars 131 forks source link

Chainer graph #398

Closed knshnb closed 5 years ago

knshnb commented 5 years ago

New features

New data(set) patterns
- sparse graph data(set)
- padding graph data(set) with coo matrix
New models
- sparse RelGCN
- sparse GIN
- GIN with coo matrix
New task
- semi-supervised node classification on large graphs
New datasets
- citation network (cora, citeseer)
- reddit

Dataset class

	Chemical	Network
adjacency matrix	`NumpyTupleDataset`	`PaddingGraphDataset`
scatter operation	`SparseGraphDataset`	`SparseGraphDataset`
sparse matmul	not supported	`PaddingGraphDataset (use_coo=True)`

corochann commented 5 years ago

updated comment

corochann commented 5 years ago

updated comment

corochann commented 5 years ago

Thank you! LGTM. I will check to run example later!

codecov-io commented 5 years ago

Codecov Report

Merging #398 into master will decrease coverage by 6.81%. The diff coverage is 27.85%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   91.22%   84.41%   -6.82%     
==========================================
  Files         229      234       +5     
  Lines       11049    11449     +400     
==========================================
- Hits        10080     9665     -415     
- Misses        969     1784     +815

corochann commented 5 years ago

@knshnb If you can add some test, please add test (coverage test is failing now, since new functionality is not tested.) But I am going to merge this PR, even though in current condition after I confirmed example code works.

corochann commented 5 years ago

I will merge this PR!

Known TODO: #400 #401