search

chainer / chainer-chemistry

Chainer Chemistry: A Library for Deep Learning in Biology and Chemistry
MIT License
618 stars 129 forks source link

Weight tying option has a bug #399

Open knshnb opened 4 years ago

knshnb commented 4 years ago

If weight_tying option is True, only one update layer is called regardless of n_update_layers

https://github.com/pfnet-research/chainer-chemistry/blob/master/chainer_chemistry/models/gin.py#L37

corochann commented 4 years ago

So we should change this line to self.n_update_layers ? https://github.com/pfnet-research/chainer-chemistry/blob/master/chainer_chemistry/models/gin.py#L92