search

chainer / chainercv

ChainerCV: a Library for Deep Learning in Computer Vision
MIT License
1.48k stars 304 forks source link

Accept pathlib.Path type for read_image. #933

Open sergeant-wizard opened 5 years ago

sergeant-wizard commented 5 years ago

This patch enables users to pass a pathlib.Path object to read_image, which is currently not possible due to the limitations cv2.imread ( cv2.imread(pathlib.Path('hoge.png')) throws a cryptic error )

sergeant-wizard commented 5 years ago

Looks like we need to wait for the drop of python 2 support :sob:

Hakuyume commented 5 years ago

FYI: Our policy about py2 support is here.

sergeant-wizard commented 5 years ago

Will ChainerCV update to Chainer 7 after its stable release and then drop Py2 support?

Hakuyume commented 5 years ago

After Chainer v7 becomes stable, we can drop py2 support from ChainerCV.

sergeant-wizard commented 5 years ago

Ok the test should pass once PY2 test is removed. I'll rebase once that happens.

On Tue, Oct 8, 2019, 4:51 PM Toru Ogawa notifications@github.com wrote:

After Chainer v7 becomes stable, we can drop py2 support from ChainerCV.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chainer/chainercv/pull/933?email_source=notifications&email_token=ABOL4ZDGUBQKGYDP5SNVT6DQNUMHZA5CNFSM4I6WDEOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAV7JFQ#issuecomment-539751574, or mute the thread https://github.com/notifications/unsubscribe-auth/ABOL4ZHLXI6XHTKSZ4LVYDDQNUMHZANCNFSM4I6WDEOA .