search

chainer / chainercv

ChainerCV: a Library for Deep Learning in Computer Vision
MIT License
1.48k stars 304 forks source link

Match the remote version to the local in CI #935

Closed beam2d closed 5 years ago

beam2d commented 5 years ago

In the current CI, when testing a pull request to Chainer (CuPy) stable branch, the script installs the master version of CuPy (Chainer). This PR fixes the script to use the stable version of CuPy (Chainer) in such a case. It will hopefully resolve some troubles after dropping Python2 in master branches.

Hakuyume commented 5 years ago

/test

pfn-ci-bot commented 5 years ago

Successfully created a job for commit fc28744:

Hakuyume commented 5 years ago

/test

pfn-ci-bot commented 5 years ago

Successfully created a job for commit eab544b:

beam2d commented 5 years ago

Reverted the change on gen_config.py and config.pbtxt. I will send PRs to Chainer and CuPy to change configs.

kmaehashi commented 5 years ago

https://github.com/cupy/cupy/pull/2577 and https://github.com/chainer/chainer/pull/8331 has merged.

Hakuyume commented 5 years ago

cupy/cupy#2577 and chainer/chainer#8331 has merged.

Those PRs should be back-ported on v6 branches.

kmaehashi commented 5 years ago

Those PRs should be back-ported on v6 branches.

How about using include_dot_git in the default config of each job? Currently nothing is configured in v6 branch and using the default config. https://github.com/chainer/chainer/blob/v6/.pfnci/config.pbtxt

Hakuyume commented 5 years ago

How about using include_dot_git in the default config of each job? Currently nothing is configured in v6 branch and using the default config. https://github.com/chainer/chainer/blob/v6/.pfnci/config.pbtxt

That is another option. However, I recommend to update v6's config.pbtxt since it is hard to maintain the default configs.

kmaehashi commented 5 years ago

That is another option. However, I recommend to update v6's config.pbtxt since it is hard to maintain the default configs.

OK, I agree with that idea, will do.

kmaehashi commented 5 years ago

Backport to v6 branch have been merged (both chainer/cupy). @beam2d Could you take a look on my comment, or should I takeover?

beam2d commented 5 years ago

Sorry for being late, I applied your comments. Thank you!

Hakuyume commented 5 years ago

/test

pfn-ci-bot commented 5 years ago

Successfully created a job for commit 4d5e6ab: