search

chainer / chainermn

ChainerMN: Scalable distributed deep learning with Chainer
https://chainer.org
MIT License
207 stars 57 forks source link

Clean up Communicator interface with changes #232

Closed kuenishi closed 6 years ago

kuenishi commented 6 years ago

This patch introduces naming rule to communicator API methods, as adding suffix _obj for Python object transfers. Also changes broadcast_data to bcast_data to unify broadcasting names to bcast, which had possibility to confuse users with broadcast_to in chainer.functions. Also it hides mpi_comm usage (except Barrier() usage). This patch also introduce MpiCommunicatorBase to make CommunicatorBase purely "virtual" interface class that has no implementation, but just interface.

kuenishi commented 6 years ago

Addressed all comments at 301c9b7 and 0bc63d0 .