search

chainer / chainermn

ChainerMN: Scalable distributed deep learning with Chainer
https://chainer.org
MIT License
207 stars 57 forks source link

Expose CommunicatorBase as communicator interface with docs #235

Closed kuenishi closed 6 years ago

kuenishi commented 6 years ago

As a result of offline discussion, we concluded to clean up Communicator interface before working on #230 and #226. This is step No.2 that depends on #232 as step No.1 .

This pull request exposes CommunicatorBase interface as it has been implicitly defined by the object returned by create_communicator function as well as official documentation. Note that split method is the only one available in MpiCommunicatorBase and I think not general enough for communicator interface used in ChainerMN.

kuenishi commented 6 years ago

TODO: rebase this once #232 is merged

kuenishi commented 6 years ago

Thank your comments. I addressed all of them at pull request #232 so the review will be continued there. @iwiwi @shu65