search

chainer / onnx-chainer

Add-on package for ONNX format support in Chainer
MIT License
85 stars 24 forks source link

Drop parameters argument from converters #212

Closed disktnk closed 5 years ago

disktnk commented 5 years ago

parameters is included in context.

before

def convert_func(..., context, parameters):
    parameters.append(p)

after

def convert_fun(..., context):
    context.parameters.append(p)
disktnk commented 5 years ago

/test

pfn-ci-bot commented 5 years ago

Successfully created a job for commit f8dd05e:

codecov-io commented 5 years ago

Codecov Report

Merging #212 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   89.88%   89.87%   -0.02%     
==========================================
  Files          24       24              
  Lines        1473     1471       -2     
==========================================
- Hits         1324     1322       -2     
  Misses        149      149
Impacted Files Coverage Δ
onnx_chainer/functions/noise.py 80% <ø> (ø) :arrow_up:
onnx_chainer/functions/converter.py 100% <ø> (ø) :arrow_up:
onnx_chainer/functions/loss.py 84% <ø> (ø) :arrow_up:
onnx_chainer/functions/array.py 90.16% <100%> (ø) :arrow_up:
onnx_chainer/functions/normalization.py 86.44% <100%> (ø) :arrow_up:
onnx_chainer/functions/connection.py 89.13% <100%> (ø) :arrow_up:
onnx_chainer/graph.py 95.65% <100%> (ø) :arrow_up:
onnx_chainer/functions/pooling.py 88.73% <100%> (ø) :arrow_up:
onnx_chainer/functions/activation.py 85.48% <100%> (ø) :arrow_up:
onnx_chainer/functions/math.py 85.71% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1a1abe...f8dd05e. Read the comment docs.