search

chainer / onnx-chainer

Add-on package for ONNX format support in Chainer
MIT License
85 stars 24 forks source link

Do not emit redundant axes for slice with `:` #232

Closed shinh closed 4 years ago

shinh commented 4 years ago

The added test was not failing even with this change, but I'm not sure how we should test this.

codecov-io commented 4 years ago

Codecov Report

Merging #232 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   90.87%   90.88%   +0.01%     
==========================================
  Files          24       24              
  Lines        1578     1580       +2     
==========================================
+ Hits         1434     1436       +2     
  Misses        144      144
Impacted Files Coverage Δ
onnx_chainer/functions/array.py 90.62% <100%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb283b1...8426c0c. Read the comment docs.